Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests crash with Swift 3.1.1 on Linux #378

Merged
merged 3 commits into from
May 12, 2017
Merged

Fix tests crash with Swift 3.1.1 on Linux #378

merged 3 commits into from
May 12, 2017

Conversation

norio-nomura
Copy link
Collaborator

@norio-nomura norio-nomura commented May 12, 2017 •
edited by jpsim
Loading

tests crash with Swift 3.1.1 on Linux:

  • SourceKittenFrameworkTests.ModuleTests/testCommandantDocsSPM
  • SourceKittenFrameworkTests.SwiftDocsTests/testSubscript
  • SourceKittenFrameworkTests.SwiftDocsTests/testBicycle

Fixes #379

@norio-nomura norio-nomura mentioned this pull request May 12, 2017
Merged
@norio-nomura
Copy link
Collaborator Author

Wait for drmohundro/SWXMLHash#130 to be merged.

@jpsim jpsim changed the title [WIP] Fix tests crash with Swift 3.1.1 on Linux Fix tests crash with Swift 3.1.1 on Linux May 12, 2017
@jpsim jpsim merged commit 1efc413 into master May 12, 2017
@jpsim jpsim deleted the nn-fix-crash-with-swift-3.1.1-on-linux branch May 12, 2017 18:51
@jpsim
Copy link
Owner

jpsim commented May 12, 2017

Thanks for the fixes @norio-nomura!

jpsim added a commit that referenced this pull request May 12, 2017
@jpsim
re-enable testExtension on Linux with Swift 3.1+
9ba289c 
now that #378 has been merged.
@norio-nomura
Copy link
Collaborator Author

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norio-nomura @jpsim